doc: mention v8.setFlagsFromString to pm #53731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
RedYetiDev
reviewed
Jul 4, 2024
| @@ -586,7 +586,8 @@ There are constraints you need to know before using this system: | |||
| * The Permission Model is initialized after the Node.js environment is set up. | |||
| However, certain flags such as `--env-file` or `--openssl-config` are designed | |||
| to read files before environment initialization. As a result, such flags are | |||
| not subject to the rules of the Permission Model. | |||
| not subject to the rules of the Permission Model. The same applies for V8 | |||
| flags that can be set via runtime through `v8.setFlagsFromString`. | |||
There was a problem hiding this comment.
Suggested change
| flags that can be set via runtime through `v8.setFlagsFromString`. | |
| flags that can be set via runtime through methods such as `v8.setFlagsFromString()`. |
IMO using 'such as' allows accounts for any future functions with this behavior that might happen without updating this document.
(nit: functions are described via () IIRC)
jasnell
approved these changes
Jul 5, 2024
RafaelGSS
added
the
commit-queue
lpinca
approved these changes
Jul 6, 2024
|
@RafaelGSS IMO you should fix the the |
nodejs-github-bot
removed
the
commit-queue
|
Landed in bea91db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case someone wonders if V8 flags that write to disk like:
--redirect-code-traces-to=is bypassing Permission Model.