Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove path.resolve from permissions.js #53729

Merged
merged 1 commit into from
Jul 8, 2024
Merged

lib: remove path.resolve from permissions.js #53729

merged 1 commit into from
Jul 8, 2024

Conversation

RafaelGSS
Copy link
Member

FWIW The tests included in fs-traversal already cover this change.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jul 4, 2024
@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Jul 4, 2024
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60084/
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 5, 2024
@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2024
@RafaelGSS RafaelGSS removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2024
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0095726 into nodejs:main Jul 8, 2024
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0095726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model process Issues and PRs related to the process subsystem.
8 participants
@RafaelGSS @nodejs-github-bot @jasnell @benjamingr @anonrig @JungMinu @marco-ippolito @H4ad