Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix V8 compilation on GCC 12 #53728

Merged
merged 1 commit into from
Jul 25, 2024

Commits on Jul 24, 2024

  1. deps: V8: cherry-pick 35888fee7bba

    Original commit message:
    
        [base] fix builds with GCC 12 on certain Linux distributions
    
        With GCC 12 on certain Linux distributions (at least Debian 12,
        Alpine 3.18, Fedora 37, that ships GCC 12.2),
        std::is_trivially_copyable is broken
        and as a result, V8 fails to compile. This patch uses the
        same polyfill on MSVC to make it compile with GCC 12.2.
    
        See nodejs#45427 for more context.
        Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc
    
        Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182
        Commit-Queue: Joyee Cheung <joyee@igalia.com>
        Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#95181}
    
    Refs: v8/v8@35888fe
    joyeecheung committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    23faf6a View commit details
    Browse the repository at this point in the history