Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: make URL.parse enumerable #53720

Closed
wants to merge 2 commits into from
Closed

url: make URL.parse enumerable #53720

wants to merge 2 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Jul 4, 2024

This PR

  1. Updates WPT WebIDL interfaces with git node wpt interfaces, updates the expectations
  2. Fixes URL.parse WebIDL by making it enumerable
@panva panva added url Issues and PRs related to the legacy built-in url module. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url
  • @nodejs/web-standards
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jul 4, 2024
@panva panva removed the url Issues and PRs related to the legacy built-in url module. label Jul 4, 2024
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60072/
@panva panva removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2024
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2024
mcollina
mcollina approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60113/
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 8736e9f...3ca05ff
nodejs-github-bot pushed a commit that referenced this pull request Jul 6, 2024
@panva @nodejs-github-bot
test: update WPT WebIDL interfaces
da3afd9 
PR-URL: #53720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 6, 2024
@panva @nodejs-github-bot
url: make URL.parse enumerable
3ca05ff 
PR-URL: #53720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva panva deleted the update-wpt branch July 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
9 participants
@panva @nodejs-github-bot @mcollina @jasnell @benjamingr @lpinca @anonrig @targos @legendecas