Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: remove prototype primordials #53699

Merged
merged 3 commits into from
Jul 7, 2024
Merged

tls: remove prototype primordials #53699

merged 3 commits into from
Jul 7, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 2, 2024

Yagiz and I paired to remove primordials in TLS files, as those are really just a JS lib that happens to be in core, not something for which prototype pollution is a big concern.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/net
  • @nodejs/tsc
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Jul 2, 2024
mcollina
mcollina approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@H4ad H4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@H4ad H4ad removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 5, 2024
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60112/
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit daea065 into nodejs:main Jul 7, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in daea065
@aduh95 aduh95 deleted the tls-bye-bye-primordials branch July 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem.