Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path: use the correct name in validateString #53669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

path: use the correct name in validateString #53669

wants to merge 1 commit into from
+2 −2

Conversation

bpasero
Copy link
Contributor

@bpasero bpasero commented Jul 1, 2024 •
edited
Loading

The change in 4a8b8d5 seems to have forgotten to update the name of the parameter in the validateString function.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Jul 1, 2024
@bpasero bpasero changed the title path - use the correct name in validateString Jul 1, 2024
MoLow
MoLow approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. commit message needs fixing
@bpasero
path: use the correct name in validateString
f99761d 
The parameter was renamed from `ext` to `suffix`
but not in the `validateString` call.
@bpasero
Copy link
Contributor Author

bpasero commented Jul 2, 2024

I have updated the commit message.
@deokjinkim deokjinkim marked this pull request as draft July 3, 2024 15:54
@deokjinkim deokjinkim marked this pull request as ready for review July 3, 2024 15:54
@deokjinkim deokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 3, 2024
@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60097/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem.
6 participants
@bpasero @nodejs-github-bot @jasnell @lpinca @deokjinkim @MoLow