Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve error performance of fs.dir #53667

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fs: improve error performance of fs.dir #53667

merged 1 commit into from
Jul 9, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 1, 2024

Reduces the C++ -> JS communication on error path by throwing the error from C++. We did the same optimization for remaining fs calls, and saw some promising results.

cc @nodejs/performance @nodejs/fs @nodejs/cpp-reviewers
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Jul 1, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 1, 2024
@anonrig anonrig requested a review from mcollina July 1, 2024 17:03
mcollina
mcollina approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60171/
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 307430e into nodejs:main Jul 9, 2024
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 307430e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings
6 participants
@anonrig @nodejs-github-bot @mcollina @lemire @jasnell @VoltrexKeyva