doc: avoid hiding by navigation bar in anchor jumping in 17.x #53663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
This was referenced Jul 1, 2024
jasnell
approved these changes
Jul 1, 2024
…re cleanly with font size adjustments
|
Node.js 17 is End-of-Life and will not get new versions. |
|
It's sad but the original PR was proposed in 2022. I guess at that time, Node 17 hadn't reached EOL yet? Two years later, the original PR was suddenly merged into the main branch (targeting the current 22.x), which caused unexpected issues. |
…top` on the headings
aymen94
approved these changes
Jul 8, 2024
It is still valuable to at least have functional documentation for older versions, even if it's just for reference. Why is this tied to Node.js releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #45131 (comment)
Merging into the v17.x branch should only affect the documentation for Node 17.