Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: split per-process initialization and teardown routines #27276

Closed
wants to merge 1 commit into from
Closed

src: split per-process initialization and teardown routines #27276

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@joyeecheung
src: split per-process initialization and teardown routines
322e9b6 
This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3282
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22522/
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22523/
@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Apr 18, 2019
@joyeecheung
Copy link
Member Author

Can I have another review please? @nodejs/process
@joyeecheung joyeecheung mentioned this pull request Apr 20, 2019
Closed
2 tasks
@joyeecheung
Copy link
Member Author

Landed in 5356b4a
joyeecheung added a commit that referenced this pull request Apr 20, 2019
@joyeecheung
src: split per-process initialization and teardown routines
5356b4a 
This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.

PR-URL: #27276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. review wanted PRs that need reviews.
4 participants
@joyeecheung @nodejs-github-bot @jasnell @addaleax