src: apply modernize-use-nullptr in node_win32_etw_provider.cc #27263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
richardlau
approved these changes
Apr 16, 2019
BridgeAR
approved these changes
Apr 16, 2019
BridgeAR
added
the
author ready
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Apr 16, 2019
This comment has been minimized.
This comment has been minimized.
2 tasks
cjihrig
approved these changes
Apr 21, 2019
refack
approved these changes
Apr 21, 2019
This comment has been minimized.
This comment has been minimized.
refack
force-pushed
the
clang_tidy_use_nullptr
branch
from
b1f5d53
to
7f7965c
Compare
This comment has been minimized.
This comment has been minimized.
PR-URL: nodejs#27263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
force-pushed
the
clang_tidy_use_nullptr
branch
from
7f7965c
to
8eaf311
Compare
refack
removed
the
author ready
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also from: https://ci.nodejs.org/job/node-clang-tidy/7/console
cc @richardlau @refack
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes