Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: pass along errors from object instantiations #25734

Closed
wants to merge 7 commits into from
Closed

src: pass along errors from object instantiations #25734

wants to merge 7 commits into from

Conversation

addaleax
Copy link
Member

Calling Function::NewInstance() can always fail in the presence of termination exceptions, so we need to check for error conditions when calling it.

This PR does not address all of those cases, but at least some of them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2403/pipeline
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 27, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20393/
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20409/
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@addaleax
Copy link
Member Author

Landed in 1a37fd6...8e6667f
@addaleax addaleax closed this Jan 29, 2019
@addaleax addaleax deleted the new-instance-1 branch January 29, 2019 19:08
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from PromiseWrap instantiation
5556975 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from stream obj instantiation
4dbff09 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from process obj instantiation
95571ac 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from perf obj instantiation
77fa310 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from KeyObject instantiation
6202096 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from vm data wrapper creation
2c18d97 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
src: pass along errors from i18n converter instantiation
8e6667f 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from stream obj instantiation
2928672 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from process obj instantiation
5add2b5 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from perf obj instantiation
ced4e71 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from KeyObject instantiation
8ee4810 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from vm data wrapper creation
deebf10 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
src: pass along errors from i18n converter instantiation
c095106 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Jan 29, 2019
Merged
joyeecheung
joyeecheung reviewed Jan 29, 2019
View reviewed changes
src/env.cc
MaybeLocal<Object> Environment::CreateProcessObject(
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args) {
if (*TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this part inside CreateProcessObject? (Or rather why is this method named CreateProcessObject?)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyeecheung Because it’s the part that handles args and exec_args, that’s pretty much all the reason … also, I called it that because that’s what it mainly does, create + set up the process object?
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2019
@addaleax
src: pass along errors from PromiseWrap instantiation
a29a712 
PR-URL: nodejs#25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax addaleax mentioned this pull request Jan 30, 2019
Closed
2 tasks
addaleax added a commit that referenced this pull request Feb 3, 2019
@addaleax
src: pass along errors from PromiseWrap instantiation
882902c 
PR-URL: #25734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

PR-URL: #25837
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos added this to Backported in v11.x Feb 10, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
5 participants
@addaleax @nodejs-github-bot @jasnell @joyeecheung @devsnek