-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapters): add triplit
adapter
#9541
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@wernst is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
@wernst thanks for the PR! I haven't looked closely so can't answer your first question yet, but the docs are mostly included as typedocs in the code as comments (in your |
@ndom91 Thanks for the info! Looks like the testing issues were related to a cjs/esm packaging issue in our js libs, so that should be resolvable on our end. I'll add the relevant typedocs comments as well. |
f44b5c6
to
38bb2cf
Compare
Hi @ndom91 , I just pushed up a commit adding the doc strings. The testing issue is also resolved. I'll let you take a look when you have a chance, but let me know if there's anything else I can be helpful with to merge the PR. Thanks for your time! |
Thanks @wernst! There do seem to be some merge conflicts atm, can you take a look at those? 🙏 |
38bb2cf
to
ec32c2b
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/react-dom@18.2.18, npm/@types/react@18.2.48, npm/prisma@5.8.1, npm/react-dom@18.3.1, npm/react@18.3.1, npm/shiki@1.3.0, npm/svelte@4.2.9 |
@ndom91 My apologies! Just rebased the branch, so those conflicts in the lock file should be resolved now. |
Thanks, looking much better! I have a few more notes, mostly small repo organisation type stuff. I'll just add them as a checklist here:
If you could take care of those, that'd be great! Also, if you haven't seen it yet, we have a guide for adding a new adapter which includes a lot of reminders / guidelines 🙏 |
ec32c2b
to
9086f6e
Compare
@ndom91 Those updates should be in (if I missed anything my apologies). I did see there was one file ( |
e09a633
to
7e88e96
Compare
7e88e96
to
b957b8c
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
b957b8c
to
681bcdf
Compare
681bcdf
to
264c933
Compare
264c933
to
3a86193
Compare
3a86193
to
d1bd3cc
Compare
d1bd3cc
to
f32a21c
Compare
Hi @ndom91 , just want to bump this one more time while I dont have a lock file conflict. Just switched over the test runner to vitest. The only outstanding question I have is whether I should edit: Thanks! |
56b72d9
to
733276e
Compare
733276e
to
b2c2845
Compare
b2c2845
to
fd84d1e
Compare
@ndom91 just rebased onto main, so bumping this |
fd84d1e
to
cf130d0
Compare
cf130d0
to
e3ca350
Compare
e3ca350
to
997610a
Compare
@ndom91 just rebased onto main, so bumping this |
This PR adds a db adapter for Triplit, a realtime database that runs on both the browser and server. We're big fans of next auth and have been using it internally for projects at Triplit, so are excited to make this adapter available to the public.
The code should work as is, however I'm running into two issues.
Thank you for any guidance.