Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set defaults for route handlers #11213

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jpulec
Copy link
Contributor

@jpulec jpulec commented Jun 20, 2024

☕️ Reasoning

Best I can tell, default setting of config options isn't happening for route handlers and middleware when you do lazy initialization. This means that basic defaults, like basePath don't get properly passed through, causing issues.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged
@jpulec jpulec requested a review from ThangHuuVu as a code owner June 20, 2024 08:07
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 8:11am
Copy link

vercel bot commented Jun 20, 2024

@jpulec is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@balazsorban44 balazsorban44 merged commit d25aefe into nextauthjs:main Jul 2, 2024
6 of 7 checks passed
@jpulec jpulec deleted the fix/correct-defaults-routes branch July 3, 2024 00:27
@jpulec jpulec restored the fix/correct-defaults-routes branch July 3, 2024 00:27
@jpulec jpulec deleted the fix/correct-defaults-routes branch July 3, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants