Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): re-introduce idToken: boolean #11161

Merged
merged 5 commits into from
Jun 14, 2024
Merged

feat(core): re-introduce idToken: boolean #11161

merged 5 commits into from
Jun 14, 2024

Conversation

balazsorban44
Copy link
Member

☕️ Reasoning

When idToken: false is set, we should use the userinfo_endpoint to get the user data.

There is a slight change here compared to v4, which is documented in the migration docs.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources
@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 10:23am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 10:23am
proxy ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 10:23am
@github-actions github-actions bot added providers core Refers to `@auth/core` labels Jun 14, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Jun 14, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@typescript-eslint/eslint-plugin@v6.19.1 None 0 2.58 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@v6.19.1 None 0 17.8 kB bradzacher, jameshenry

View full report↗︎
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 27.53623% with 50 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c9c6f0b). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files Patch % Lines
...es/core/src/lib/actions/callback/oauth/callback.ts 9.52% 38 Missing ⚠️
packages/core/src/providers/index.ts 42.85% 12 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11161   +/-   ##
=======================================
  Coverage        ?   42.16%           
=======================================
  Files           ?      177           
  Lines           ?    28368           
  Branches        ?     1244           
=======================================
  Hits            ?    11960           
  Misses          ?    16408           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@balazsorban44 balazsorban44 marked this pull request as ready for review June 14, 2024 10:17
@balazsorban44 balazsorban44 merged commit b56b928 into main Jun 14, 2024
8 of 10 checks passed
@balazsorban44 balazsorban44 deleted the feat/support-jwt-signed-userinfo branch June 14, 2024 10:17
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
@balazsorban44
feat(core): re-introduce idToken: boolean (nextauthjs#11161)
e386718 
* feat(core): support JWT signed userinfo endpoint response

* chore(deps): bump `oauth4webapi`

* use `idToken: boolean` instead

* docs: mention `idToken` changed behavior

* move helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
1 participant
@balazsorban44