Partial Vb.NET support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got the basics working
However, all the code style changes make reviewing what's changed much harder. :/ |
so don't get weird inconsistency bugs
I noticed it while here so chose to fix that too.
mrlacey
reviewed
Apr 26, 2023
| @@ -48,7 +48,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.VisualStudio.SDK"> | |||
| <Version>17.2.32505.173</Version> | |||
| <Version>17.5.33428.388</Version> | |||
There was a problem hiding this comment.
Was there a need to increase the target SDK?
mrlacey
reviewed
Apr 26, 2023
| try | ||
| { | ||
| // Some document types (inc. .csproj) throw an error when try and get the ActiveDocument | ||
| // "The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))" | ||
| return await Task.FromResult(dte?.ActiveDocument); | ||
| EnvDTE.Document doc = await Task.FromResult(dte?.ActiveDocument); | ||
| return doc != null && (doc.Language == "CSharp" || doc.Language == "Basic") ? doc : null; |
There was a problem hiding this comment.
Why is this language check needed?
How do you even get this code to execute to this line if not in a supported language?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.