Fix all topics filtering

kitsune/questions/jinja2/questions/question_list.html

@@ -118,10 +118,6 @@ <h1 class="sumo-page-heading {% if not logo %}no-logo{% endif %}">
 </section>
 {% endblock %}
 
-
-
-
-
 {% block content %}
 {% if tags %}
   <div id="tagged" class="tag-notification">
@@ -314,7 +310,7 @@ <h3 class="sidebar-subheading">{{ _('Filter by') }}</h3>
         <li class="sidebar-subheading sidebar-nav--heading-item">{{ _('Topic') }}</li>
         <li>
           <select id="products-topics-dropdown">
-            <option value="{{ url('questions.list_by_topic', topic_slug=topic_slug) }}" {% if selected_topic is none %}selected{% endif %}>
+            <option value="{{ url('questions.list', product_slug='all') }}" {% if selected_topic is none %}selected{% endif %}>
               All Topics
             </option>
             {% for topic in topic_list %}

kitsune/questions/views.py

@@ -162,8 +162,6 @@ def question_list(request, product_slug=None, topic_slug=None):
             )
             return HttpResponseRedirect("/")
 
-        products = None
-
     # Get all topics
     topics = []
     topic_navigation = False

kitsune/sumo/static/sumo/js/topics.js

@@ -1,7 +1,7 @@
 document.addEventListener('DOMContentLoaded', function () {
     var dropdown = document.getElementById('products-topics-dropdown');
     dropdown.addEventListener('change', function () {
-        var selectedUrl = this.value;
+        let selectedUrl = this.value;
         if (selectedUrl) {
             window.location.href = selectedUrl;
         }