Migrate Documents to new Topics #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
reviewed
Jun 24, 2024
| "emails-thunderbird", | ||
| "set-up-email-thunderbird", | ||
| ], | ||
| "customize-settings-and-preferences": [ |
There was a problem hiding this comment.
This list is missing sync.
There was a problem hiding this comment.
I know - it just felt weird to pull out sync from the Sync topics and I wanted to reconfirm this with the content team
akatsoulas
force-pushed
the
migrate-topics
branch
from
78688d0
to
0b9ee72
Compare
|
@escattone this should be ready for a review. I tested it locally and it runs without errors |
escattone
approved these changes
Jun 25, 2024
| document.topics.remove(source_topic) | ||
|
|
||
| # Migrate questions to the new topic | ||
| if source_topic.questions.exists(): |
There was a problem hiding this comment.
Nit. I don't think this line is needed, since the source_topic.questions.all() below will return an empty list if the topic has no associated questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.