Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving playwright kb restricted visibility tests #6038

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Improving playwright kb restricted visibility tests #6038

merged 1 commit into from
Jun 3, 2024

Conversation

emilghittasv
Copy link
Collaborator

  • Removing some repetitive steps inside the "KB - Restricted Visibility" tests & adding a helper function for the restricted visibility group removal flow.
@emilghittasv
- Removing some repetitive steps inside the "KB - Restricted Visibili…
aa19179 
…ty" tests & adding a helper function for the restricted visibility group removal flow.
@emilghittasv emilghittasv force-pushed the playwright_restricted_visibility_improvements branch from 00befd3 to aa19179 Compare June 3, 2024 16:23
@emilghittasv
Copy link
Collaborator Author

@akatsoulas I've updated the code based on your suggestion.

Thanks for the feedback! It's definitely cleaner.
@emilghittasv emilghittasv merged commit b2f2de5 into mozilla:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@emilghittasv @akatsoulas