optipng won't compile on mac silicon #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a Make option 'init-mac' to account for it
- allow run-boostrap.sh to process the new --optipng-fix flag
Open to better ideas (yes, move to linux is valid)
- Determining if you are on Apple silicon from
run-bootstrap directly appeared to be problematic
since it is running in a container
- Doing it prior in the make call seemed to make sense
- change nothing for exisitng processes but add a
simpler way forward for Mac folk
escattone
reviewed
Jul 17, 2023
|
@smithellis / @escattone do we still need this or shall we close the PR? |
|
I'm pretty sure optipng compiles properly now. Let's close and reopen if necessary. |
|
Re-opening this PR, since compiling |
escattone
approved these changes
May 1, 2024
|
Since this is a small feature addition that doesn't affect anyone unless they're a Mac M1/M2 user that needs it, I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open to better ideas (yes, move to linux is valid)