Merge pull request #6001 from akatsoulas/default-user-msg

Populate username by default

kitsune/messages/views.py

@@ -85,7 +85,11 @@ def outbox(request):
 
 @login_required
 def new_message(request):
-    form = MessageForm(request.POST or None, user=request.user)
+    data = request.POST or None
+    form_kwargs = {"user": request.user}
+    if not data:
+        form_kwargs["initial"] = request.GET.dict()
+    form = MessageForm(data, **form_kwargs)
     if form.is_valid() and not is_ratelimited(request, "private-message-day", "50/d"):
         send_message(
             form.cleaned_data["to"],

kitsune/sumo/form_fields.py

@@ -92,22 +92,24 @@ def to_python(self, value):
         if not value:
             if self.required:
                 raise ValidationError(_("To field is required."))
-            else:
-                return []
+            return []
 
         # This generator expression splits the input string `value` by commas to extract
         # parts, strips whitespace from each part, and then further splits each non-empty
         # part by the colon.
         # Each resulting pair of values (before and after the colon) is stripped of
-        # any extra whitespace and returned as a tuple. This process is done lazily,
-        # generating each tuple only when iterated over.
         key_value_pairs = (
-            tuple(map(str.strip, part.split(":"))) for part in value.split(",") if part.strip()
+            tuple(map(str.strip, (part if ":" in part else "user: " + part).split(":")[:2]))
+            for part in value.split(",")
+            if part.strip()
         )
 
         # Create data structure to hold values grouped by keys
         to_objects = {}
         for key, value in key_value_pairs:
+            # check if the value is a valid username in the database
+            if not User.objects.filter(username=value).exists():
+                raise ValidationError(_(f"{value} is not a valid username."))
             to_objects.setdefault(f"{key.lower()}s", []).append(value)
 
         return to_objects