Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for mntor 3018 #4776

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Adding test for mntor 3018 #4776

merged 1 commit into from
Jul 9, 2024

Conversation

jespy2
Copy link
Contributor

@jespy2 jespy2 commented Jul 8, 2024 •
edited
Loading

References:

Jira: MNTOR-3018

Description

Added unit tests to confirm that "add email address" button is shown for users with up to 4 email addresses, and hidden when they reach five

How to test

Run unit tests locally

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
@jespy2 jespy2 requested a review from Vinnl July 8, 2024 18:00
@jespy2 jespy2 marked this pull request as ready for review July 8, 2024 18:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Preview URL 🚀 : https://blurts-server-pr-4776-mgjlpikfea-uk.a.run.app
Vinnl
Vinnl approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!
@Vinnl Vinnl force-pushed the adding-test-for-mntor-3018 branch from 3a46dd4 to de786c9 Compare July 9, 2024 11:42
@Vinnl Vinnl merged commit c2f4145 into main Jul 9, 2024
15 checks passed
@Vinnl Vinnl deleted the adding-test-for-mntor-3018 branch July 9, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Cleanup completed - database 'blurts-server-pr-4776' destroyed, cloud run service 'blurts-server-pr-4776' destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@jespy2 @Vinnl