Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-2833 #4759

Merged
merged 4 commits into from
Jul 8, 2024
Merged

MNTOR-2833 #4759

merged 4 commits into from
Jul 8, 2024

Conversation

jespy2
Copy link
Contributor

@jespy2 jespy2 commented Jul 5, 2024 •
edited
Loading

References:

Jira: MNTOR-2833

Description

Duplicated text “Subscribe to ⁨Monitor Plus⁩ and we’ll and we’ll scan..."
Screenshot 2024-07-05 at 11 25 43 AM

How to test

  1. In Storybook navigate to Pages/Logged in/Dashboard/US user, without Premium, with 0 scan results, with all breaches resolved
  2. Confirm text has been updated (as seen in this screenshot)
Screenshot 2024-07-05 at 11 26 12 AM

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
@jespy2 jespy2 requested review from Vinnl, codemist and flozia July 5, 2024 17:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Preview URL 🚀 : https://blurts-server-pr-4759-mgjlpikfea-uk.a.run.app
@jespy2 jespy2 marked this pull request as ready for review July 5, 2024 17:51
@jespy2 jespy2 requested a review from flodolo as a code owner July 5, 2024 17:51
Vinnl
Vinnl approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh whoops 😅 I'm assuming the localisers didn't copy that mistake, haha.
@flodolo
Copy link
Collaborator

flodolo commented Jul 8, 2024

Heh whoops 😅 I'm assuming the localisers didn't copy that mistake, haha.

That file is not localized ;-) (luckily)
@jespy2 jespy2 merged commit 3d77f9b into main Jul 8, 2024
15 checks passed
@jespy2 jespy2 deleted the mntor-2833 branch July 8, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Cleanup completed - database 'blurts-server-pr-4759' destroyed, cloud run service 'blurts-server-pr-4759' destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@jespy2 @flodolo @Vinnl