Add wagtail-localize-smartling to the project, for Smartling L10N support #14794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejalim
requested review from
robhudson,
alexgibson and
pmac
and removed request for
alexgibson
|
Review tagging is more about awareness than close reviewing right now. Good to get this merged (when the infra is ready) |
linjinguang39
approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14794 +/- ##
=======================================
Coverage 77.29% 77.30%
=======================================
Files 160 160
Lines 8281 8282 +1
=======================================
+ Hits 6401 6402 +1
Misses 1880 1880 ☔ View full report in Codecov by Sentry. |
robhudson
reviewed
Jul 8, 2024
stevejalim
commented
Jul 8, 2024
stevejalim
added
Do Not Merge ⚠️
Backend
stevejalim
force-pushed
the
14774-set-up-wagtail-localize-smartling
branch
from
887fe4d
to
7931a8b
Compare
|
Secrets deployed to dev and will not crash when code reaches Stage or Prod because we have non-exploding (but deliberately invalid) defaults set of |
pmac
reviewed
Jul 15, 2024
pmac
approved these changes
Jul 15, 2024
robhudson
reviewed
Jul 15, 2024
|
|
||
| .. note:: | ||
|
|
||
| It's worth investing 15 mins in watching the `Wagtail Localize original demo`_ to get a good feel of how it can work. |
There was a problem hiding this comment.
Just noticing the above text looks like it's wrapped whereas this new text isn't.
robhudson
approved these changes
Jul 15, 2024
stevejalim
force-pushed
the
14774-set-up-wagtail-localize-smartling
branch
from
c0dc2ab
to
6962f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This changeset drops in wagtail-localize-smartling, which will flow strings from Wagtail to Smartling for L10N and then back again.
Significant changes and points to review
0.2.3 is an early-ish, Minimum Lovable Product version, and there may well be some fast-follow changes from the vendor - those are in discussion at the mo, and we can pick up anything else we want, as it's "our" codebase now.
I've tested it manually, locally, for now, with sandbox-y API keys and it works for the core cases. There are some rough edges but we'll sort them out.
The infra PR needed to accompany these changes will need to:
Issue / Bugzilla link
Resolves #14774
Testing
N/A for now - I'll record a video demo, but waiting to see if there'll be a 0.2.4 soon (or not yet)