Add cursor: pointer to details summary on /cookie-settings/ page (Fixes #14781) #14782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
P3
janbrasna
reviewed
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14782 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 159 159
Lines 8239 8239
=======================================
Hits 6359 6359
Misses 1880 1880 ☔ View full report in Codecov by Sentry. |
reemhamz
approved these changes
Jul 8, 2024
| @@ -80,6 +80,11 @@ main { | |||
|
|
|||
| .cookie-summary { | |||
| border-bottom: 1px solid $color-light-gray-40; | |||
|
|
|||
| // Temporary fix until https://github.com/mozilla/protocol/issues/948 is added | |||
| &:hover { | |||
There was a problem hiding this comment.
Not a blocker, but I don't think &:hover is really necessary since it performs the same action
linjinguang39
approved these changes
Jul 8, 2024
alexgibson
force-pushed
the
cookie-setting-hover
branch
from
64b26f3
to
d7ffa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Adds
cursor: pointer;to<summary>elements on hover in /cookie-settings/ pageIssue / Bugzilla link
#14781
Testing
http://localhost:8000/en-US/privacy/websites/cookie-settings/