Ensure the lang-fixup redirects set a Vary header for Accept-Language #14500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we relied on similar code deep in lib.l10n_utils.render, but BedrockLangFixupMiddleware runs way before then, so we need(ed) to add the Vary header here, too. The orginal code in l10n_utils.render still has value, because it handles the fallback for a missing/unactive language to en-US
…d to upload, dealing with a breaking change in actions/upload-artifact
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14500 +/- ##
=======================================
Coverage 76.44% 76.45%
=======================================
Files 148 148
Lines 7978 7980 +2
=======================================
+ Hits 6099 6101 +2
Misses 1879 1879 ☔ View full report in Codecov by Sentry. |
robhudson
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on similar code deep in lib.l10n_utils.render, but BedrockLangFixupMiddleware runs way before then, so we need(ed) to add the Vary header here, too.
The orginal code in l10n_utils.render still has value, because it handles the fallback for a missing/unactive language to en-US
Issue / Bugzilla link
Resolves #14498
Testing
Check the headers when you go to / and it redirects to /en-US/ (or whatever your browser's local language is)