Upgrade upload-artifact action to v4, based on Node 20 #14371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though V4 has breaking changes, particuarly around how uploads with non-unique names are no longer automatically combined this won't be a problem here, I think Resolves mozilla#14147
|
@alexgibson If this somehow does break CI, just revert it until I'm around to do an accompanying code change, but I don't think we'll have pain from this change |
alexgibson
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though V4 has breaking changes, particuarly around how uploads with non-unique names are no longer automatically combined this won't be a problem here, I think
Resolves #14147