Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions to use Node 20 runtime #14302

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Conversation

stevejalim
Copy link
Collaborator

@stevejalim stevejalim commented Mar 11, 2024

One-line summary

Update our GHAs to use the latest node-20-based workflow, as the node-16 ones are deprecated and we don't want to be caught out if they stop working.

Issue / Bugzilla link

Resolves #14147

Testing

Some of these we can run directly from the branch, but really we should just merge and see how they are. The only that looks like it might need a bit of tuning is upload_artifact and we'll see that as soon as this PR hits main

@stevejalim stevejalim changed the title 14147 gha updates Mar 12, 2024
@stevejalim stevejalim changed the title Update Gituhub Actions to use Node 20 runtime Mar 12, 2024
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine. My only question would be if we should split this up into multiple things to update. But if we're OK with just seeing how things go and rolling something back if it goes south, that sounds low risk enough to me. r+

Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁

@stevejalim stevejalim merged commit b1ed1c9 into main Mar 12, 2024
6 checks passed
@stevejalim stevejalim deleted the 14147-gha-updates branch March 12, 2024 15:22
@janbrasna
Copy link
Contributor

@stevejalim Yup the upload-artifact still yields warnings e.g. run:8456030154 — what was the problem with it again?

I see it as checked off in #14147 but not changed in the PR:

- name: Store artifacts
if: always()
uses: actions/upload-artifact@v3
with:
name: test-results
path: results-${{github.run_id}}-${{matrix.label}}
if-no-files-found: ignore # this avoids a false "Warning" if there were no issues

@stevejalim
Copy link
Collaborator Author

@janbrasna IIRC I backed out the change pre-push for upload-artifact because I didn't want to risk breaking our integration tests (which upload screenshots of failures) and v4 chnages behaviours surrounding same-named files compared to v3.

I've unticked it from #14147 for now and will re-open that ticket as it has two things to deal with.

Thanks for the poke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants