-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions to use Node 20 runtime #14302
Conversation
a2be674
to
f6b1a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes seem fine. My only question would be if we should split this up into multiple things to update. But if we're OK with just seeing how things go and rolling something back if it goes south, that sounds low risk enough to me. r+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎁
@stevejalim Yup the I see it as checked off in #14147 but not changed in the PR: bedrock/.github/workflows/integration_tests.yml Lines 101 to 107 in 0a993cb
|
@janbrasna IIRC I backed out the change pre-push for I've unticked it from #14147 for now and will re-open that ticket as it has two things to deal with. Thanks for the poke! |
One-line summary
Update our GHAs to use the latest node-20-based workflow, as the node-16 ones are deprecated and we don't want to be caught out if they stop working.
Issue / Bugzilla link
Resolves #14147
Testing
Some of these we can run directly from the branch, but really we should just merge and see how they are. The only that looks like it might need a bit of tuning is
upload_artifact
and we'll see that as soon as this PR hitsmain