-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old obsolete strings from Fluent files #13886
Conversation
6baa05a
to
f288b25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very through 💯 Just needs a rebase to fix the conflicts.
@@ -248,7 +248,6 @@ <h3>{{ ftl('privacy-book-stay-safe-online') }}</h3> | |||
<li>{{ ftl('privacy-book-some-online-services') }}</li> | |||
<li> | |||
<p>{{ ftl('privacy-book-wondering-how-youre') }}</p> | |||
<p>{{ ftl('privacy-book-there-are-several-v2', fallback='privacy-book-there-are-several') }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. 🔒
@@ -6,7 +6,7 @@ | |||
|
|||
{% extends "firefox/whatsnew/base.html" %} | |||
|
|||
{% block page_title %}{{ ftl('whatsnew-page-title') }}{% endblock %} | |||
{% block page_title %}{{ ftl('whatsnew-page-title-v2' ,fallback='whatsnew-page-title') }}{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The space is on the wrong side of the comma (for all the WNP titles)
If fixing this fills you with dread we can totally leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If fixing this fills you with dread we can totally leave it.
Well when you put it like that... 😝 j/k, I'll fix it
c663f6d
to
fd86bd8
Compare
fd86bd8
to
c7b45a2
Compare
^ Seems like I also committed a file that was updated in this PR: #13900 by the rebase I just did 🤦🏻♀️, but it seems very minimal and harmless (since it's a small string update) so I'll just proceed and merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+
One-line summary
Removing old (3+ months) obsolete Fluent strings from Fluent files and any mention of them from HTML files (usually placed in
fallback
helpers)✍🏼 Things to note: ✍🏼
Issue / Bugzilla link
#13714
Testing
The following are pages whose HTML files were edited to remove old strings in
fallback
/ftl_has_messages
helpersDid I miss anything?
WNP page title string updates: