-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10631: Get CircleCI to store Python coverage report #10640
10631: Get CircleCI to store Python coverage report #10640
Conversation
59d0624
to
88d7ab1
Compare
Codecov Report
@@ Coverage Diff @@
## master #10640 +/- ##
=========================================
Coverage ? 69.42%
=========================================
Files ? 149
Lines ? 8402
Branches ? 0
=========================================
Hits ? 5833
Misses ? 2569
Partials ? 0 Continue to review full report at Codecov.
|
@robhudson @pmac So we've got coverage metrics being pumped back into the PR. This one lacks a base commit to compare to, so we might find we need to do a bit of tuning, but there is (deliberately) no config that fails CI or similar based on a change in coverage so I (famous last words) think we won't get any blocked PRs because of this. We can look to add strict checks in the future, if we decide it's wortwhile. |
88d7ab1
to
2c6e39c
Compare
Am 95% sure that the |
..so that artefacts end up in the expected place for downstream processing
2c6e39c
to
296dc1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Let's give it a try 🍰
Excited to start seeing these! |
Description
Now we have coverage.py running again, we want to surface the metrics at CI level.
This changeset stores the output of the coverage checks as a CircleCI artefact.
We then use CodeCov to report on the result. The CodeCov integration is powered by their own Orb, which runs verification checks on the uploader script to ensure its integrity - you can see those steps happen in CircleCI
Issue / Bugzilla link
#10631
Testing
python_coverage
dir existing in the artefacts for the build.