Skip to content

Commit

Permalink
Fluent linter: add checks for Fakespot and incorrect brand combinatio…
Browse files Browse the repository at this point in the history
…n for accounts
  • Loading branch information
flodolo authored and alexgibson committed May 3, 2024
1 parent eb92898 commit 879ad5c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/l10n/linter_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ ID02:
CO01:
enabled: true
brands:
- Fakespot
- Firefox
- Mozilla
- Pocket
- "{ -brand-name-mozilla } account"
exclusions:
files: []
messages:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/fluent_linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
- name: Set up Python 3
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: "3.11"
- name: Install Python dependencies
run: |
pip install moz-fluent-linter==0.3.*
pip install moz-fluent-linter==0.4.*
- name: Lint mozilla.org files
run: |
moz-fluent-lint l10n/en --config .github/l10n/linter_config.yml
Expand Down
2 changes: 1 addition & 1 deletion l10n/en/firefox/products.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ firefox-products-download-thunderbird = Download { -brand-name-thunderbird }
firefox-products-fakespot = { -brand-name-fakespot }
# scam artists are people who are trying to sell fakes or steal money
# 'weeding' is a gardening term, here it is used to mean "removing unwanted things without touching the good ones"
firefox-products-fakespot-has-your = Fakespot has your back when you’re shopping online — weeding out scam artists and finding you the best deals.
firefox-products-fakespot-has-your = { -brand-name-fakespot } has your back when you’re shopping online — weeding out scam artists and finding you the best deals.
firefox-products-analyze = Analyze a URL
## Pocket
Expand Down
2 changes: 1 addition & 1 deletion l10n/en/privacy/cookie-settings.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ cookie-settings-turn-on-javascript = Please turn on JavaScript to update your Co
cookie-settings-category-necessary-heading = Necessary
cookie-settings-category-necessary-what-are-subheading = What are Necessary Cookies?
cookie-settings-category-necessary-what-are-desc = These technologies are required to support essential website features, such as logging into a secure area of a website or adding items to an online shopping basket, and cannot be turned off.
cookie-settings-category-necessary-how-does-desc = { -brand-name-mozilla } uses Necessary Cookies only to provide essential website features, such as logging in using your { -brand-name-mozilla } account or purchasing a software subscription at checkout. Without these technologies, essential website features may not function.
cookie-settings-category-necessary-how-does-desc-v2 = { -brand-name-mozilla } uses Necessary Cookies only to provide essential website features, such as logging in using your { -brand-name-mozilla-account } or purchasing a software subscription at checkout. Without these technologies, essential website features may not function.
## Preference cookies section

Expand Down

0 comments on commit 879ad5c

Please sign in to comment.