VPN-5588 Add OS Version to balrog requests #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
approved these changes
Jun 25, 2024
lesleyjanenorton
approved these changes
Jun 25, 2024
strseb
added a commit
that referenced
this pull request
Jun 26, 2024
* Pass OS version to balrog * lint * Fix win build
Merged
strseb
added a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to -> mozilla-releng/balrog#3071
We can now add the OS version to balrog requests to depricate specific versions.
This PR adds the env::Osversion into that request. Also we change the behavior of windows detection, we just report build number. Otherwise we can only select for "Windows 11 or Windows 10" vs windows 11-22-H1.
Just see how many builds there are 💀
https://learn.microsoft.com/en-us/windows/release-health/windows11-release-information
https://learn.microsoft.com/en-us/windows/release-health/release-information