Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-6429: remove metrics and update expirations #9671

Merged
merged 2 commits into from
Jun 20, 2024
Merged

VPN-6429: remove metrics and update expirations #9671

merged 2 commits into from
Jun 20, 2024

Conversation

mcleinman
Copy link
Collaborator

Description

I removed the metrics listed in the ticket. Where signals/slots/functions/etc. only existed for the metric recording, I removed them as well.

Reference

VPN-6429

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed
oskirby
oskirby approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good
@mcleinman mcleinman force-pushed the vpn-6429-remove-unneeded-metrics branch from 61dfa6b to 7c03fbd Compare June 20, 2024 20:19
@mcleinman mcleinman force-pushed the vpn-6429-remove-unneeded-metrics branch from 7c03fbd to b49a21a Compare June 20, 2024 20:31
@mcleinman mcleinman merged commit 5535adc into main Jun 20, 2024
113 checks passed
@mcleinman mcleinman deleted the vpn-6429-remove-unneeded-metrics branch June 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@mcleinman @oskirby @strseb