Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6423: Fix TestQmlPath on Qt 6.6.0 and later #9657

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Jun 11, 2024

Description

The TestQmlPath test has been failing for me on Qt 6.6.0 and later, and after a bit digging I traced the crash down into the depths of Qt, which was failing at qquickpathview.cpp:68:75 with the expression QGuiApplicationPrivate::platformIntegration() returning a null pointer. This occurs because the app unit tests are invoked as QCoreApplication instead of a QGuiApplication so the platform integration plugins are never initialized, leading to the segmentation fault in the QML engine.

There are two reasonable ways to fix this issue:

  1. We move this test case into the QML Tests, which does initialize the Gui and QML engine, or
  2. We just convert the app unit tests into a GUI application.

I have gone with option 2 here.

Reference

JIRA issue: VPN-6423

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed
@oskirby oskirby force-pushed the vpn-6423-fix-qmlpath-tests branch from 7c72aa8 to b466192 Compare June 11, 2024 22:24
@oskirby oskirby marked this pull request as ready for review June 12, 2024 07:27
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oskirby oskirby merged commit c8a95d7 into main Jun 14, 2024
113 of 114 checks passed
@oskirby oskirby deleted the vpn-6423-fix-qmlpath-tests branch June 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants