Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros): mark interface.ejs as deprecated #6011

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

teoli2003
Copy link
Member

@teoli2003 teoli2003 commented Apr 20, 2022

We have removed the interface macro from mdn/content:

rg "\{ *interface" | wc -l
      0

Still 288 in mdn/translated-content.

Meanwhile, we want to be sure they don't reappear in mdn/content, so marking it as deprecated will warn us in the flaw system if a new one is added. (As we have 0 deprecated macros left in mdn/content, we will notice it.)

For translators: this was used to mark internal Firefox interfaces, so this should be used only for links to outdated/removed parts of mdn (E.g. {{interface("nsIDOMWindowUtils")}}) Replacing them by the argument in codeface should do it: (E.g. nsIDOMWindowUtils).

kumascript/macros/interface.ejs Outdated Show resolved Hide resolved
@caugner caugner changed the title Mark interface.ejs as deprecated Apr 20, 2022
@caugner caugner added 🧑‍🤝‍🧑 community contributions by our wonderful community macros tracking issues related to kumascript macros labels Apr 20, 2022
Co-authored-by: Claas Augner <github@caugner.de>
@teoli2003 teoli2003 requested a review from caugner April 23, 2022 06:35
@caugner caugner merged commit 5569d30 into mdn:main Apr 25, 2022
@caugner
Copy link
Contributor

caugner commented Apr 25, 2022

Thanks @teoli2003!

OnkarRuikar pushed a commit to OnkarRuikar/yari that referenced this pull request Jun 2, 2022
Co-authored-by: Claas Augner <github@caugner.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍🤝‍🧑 community contributions by our wonderful community macros tracking issues related to kumascript macros
2 participants