Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {{ifmethod}} and {{ifattribute}} macros from l10n-zh #5533

Merged
merged 2 commits into from
May 10, 2022
Merged

Remove {{ifmethod}} and {{ifattribute}} macros from l10n-zh #5533

merged 2 commits into from
May 10, 2022

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented May 10, 2022 •
edited
Loading

Part of mdn/mdn-community#67

Regexp I have used:

  • (?i){{[ ]?ifmethod[ ]?\(["'](\S*)["'],[ ]?["'](\S*)["'][ ]?\)[ ]?}} replaced with <code>$1.$2()</code> for HTML and `$1.$2()` for markdown.
  • (?i){{[ ]?ifattribute[ ]?\(["'](\S*)["'],[ ]?["'](\S*)["'][ ]?\)[ ]?}} replaced with <code>$1.$2</code> for HTML and `$1.$2` for markdown.
@yin1999 yin1999 requested a review from a team as a code owner May 10, 2022 07:41
@yin1999 yin1999 requested review from t7yang and removed request for a team May 10, 2022 07:41
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label May 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /zh-CN/docs/Mozilla/Firefox/Releases/22
Title: Firefox 22 for developers
on GitHub
Flaw count: 20

  • macros:
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/preventExtensions redirects to /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/preventExtensions
    • /zh-CN/docs/Web/API/XMLHttpRequest/FormData redirects to /zh-CN/docs/Web/API/FormData
    • /zh-CN/docs/Web/API/Node/setUserData does not exist
    • /zh-CN/docs/Web/API/Node/getUserData does not exist
    • /zh-CN/docs/Web/API/DeviceLightEvent does not exist
    • and 7 more flaws omitted
  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments
    • Can't resolve /en-US/docs/Server-sent_events
    • Can't resolve /en-US/docs/WebSockets
    • Can't resolve https://developer.mozilla.org/en-US/docs/CSS/Tutorials/Using_CSS_flexible_boxes
    • and 3 more flaws omitted

URL: /zh-CN/docs/Mozilla/Firefox/Releases/15
Title: Firefox 15 for developers
on GitHub
Flaw count: 20

  • macros:
    • /zh-CN/docs/Web/API/DeviceLightEvent does not exist
    • /zh-CN/docs/Web/API/UserProximityEvent does not exist but fell back to /en-US/docs/Web/API/UserProximityEvent
  • broken_links:
    • Can't resolve /zh-cn/DOM/MouseEvent
    • Can't resolve /zh-cn/DOM/KeyboardEvent#Attributes_location
    • Can't resolve /zh-cn/DOM/KeyboardEvent#Virtual_key_codes
    • Can't resolve /zh-cn/DOM/range.detach
    • Can't resolve /zh-cn/API/WebSMS
    • and 13 more flaws omitted

URL: /zh-CN/docs/Mozilla/Firefox/Releases/32
Title: Firefox 32 for developers
on GitHub
Flaw count: 29

  • macros:
    • /zh-CN/docs/Web/API/NavigatorLanguage/languages does not exist but fell back to /en-US/docs/Web/API/Navigator/languages
    • /zh-CN/docs/Web/API/KeyboardEvent/getModifierState does not exist but fell back to /en-US/docs/Web/API/KeyboardEvent/getModifierState
    • /zh-CN/docs/Web/API/InstallPhaseEvent does not exist
    • /zh-CN/docs/Web/API/NavigatorUserMedia/getUserMedia does not exist
  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Web_Audio_Editor
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Scratchpad#Code_completion_and_inline_documentation
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Page_Inspector#Rules_view
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Page_Inspector#Firefox_32_onwards_2
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Page_Inspector#Firefox_32_onwards
    • and 20 more flaws omitted

URL: /zh-CN/docs/Mozilla/Firefox/Releases/12
Title: Firefox 12 for developers
on GitHub
Flaw count: 31

  • macros:
    • /zh-CN/docs/Web/API/Window/navigator/connection does not exist
    • /zh-CN/docs/Web/API/Window/navigator/mozTelephony does not exist
    • /zh-CN/docs/Web/API/Window/navigator/mozSms does not exist
    • /zh-CN/docs/Web/API/Window/screen/mozEnabled does not exist
    • /zh-CN/docs/Web/API/Window/screen/mozBrightness does not exist
    • and 2 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/JavaScript/Sharp_variables_in_JavaScript
    • Can't resolve /en-US/docs/data_URIs
    • Can't resolve /en-US/docs/DOM/Touch_events
    • Can't resolve /en-US/docs/CSS/Using_CSS_transforms
    • and 19 more flaws omitted

URL: /zh-CN/docs/Web/API/Window/innerHeight
Title: Window.innerHeight
on GitHub
Flaw count: 3

  • macros:
    • Unknown macro todo
  • images:
    • External image URL
  • translation_differences:
    • Differences in the important macros (1 in common of 5 possible)

URL: /zh-TW/docs/orphaned/Mozilla/Firefox/Releases/4/Firefox_4_開發者新功能概覽
Title: Firefox 4 for developers
on GitHub
Flaw count: 66

  • macros:
    • /zh-TW/docs/Web/HTML/Element/article does not exist but fell back to /en-US/docs/Web/HTML/Element/article
    • /zh-TW/docs/Web/HTML/Element/section does not exist but fell back to /en-US/docs/Web/HTML/Element/section
    • /zh-TW/docs/Web/HTML/Element/aside does not exist but fell back to /en-US/docs/Web/HTML/Element/aside
    • /zh-TW/docs/Web/HTML/Element/hgroup does not exist but fell back to /en-US/docs/Web/HTML/Element/hgroup
    • /zh-TW/docs/Web/HTML/Element/header does not exist but fell back to /en-US/docs/Web/HTML/Element/header
    • and 26 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en/HTML/HTML5
    • Can't resolve /en/SVG
    • Can't resolve /en/MathML
    • Can't resolve /en/HTML/HTML5/Forms_in_HTML5
    • and 30 more flaws omitted

URL: /zh-TW/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 技術文件
on GitHub
Flaw count: 66

  • macros:
    • /zh-TW/docs/Web/HTML/Element/article does not exist but fell back to /en-US/docs/Web/HTML/Element/article
    • /zh-TW/docs/Web/HTML/Element/section does not exist but fell back to /en-US/docs/Web/HTML/Element/section
    • /zh-TW/docs/Web/HTML/Element/aside does not exist but fell back to /en-US/docs/Web/HTML/Element/aside
    • /zh-TW/docs/Web/HTML/Element/hgroup does not exist but fell back to /en-US/docs/Web/HTML/Element/hgroup
    • /zh-TW/docs/Web/HTML/Element/header does not exist but fell back to /en-US/docs/Web/HTML/Element/header
    • and 26 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en/HTML/HTML5
    • Can't resolve /en/SVG
    • Can't resolve /en/MathML
    • Can't resolve /en/HTML/HTML5/Forms_in_HTML5
    • and 30 more flaws omitted

URL: /zh-TW/docs/Mozilla/Firefox/Releases/10
Title: Firefox 10 技術文件
on GitHub
Flaw count: 79

  • macros:
    • /zh-TW/docs/Web/HTML/Element/bdi does not exist but fell back to /en-US/docs/Web/HTML/Element/bdi
    • /zh-TW/docs/Web/API/Document/xmlVersion does not exist but fell back to /en-US/docs/Web/API/Document/xmlVersion
    • /zh-TW/docs/Web/API/Document/xmlVersion does not exist but fell back to /en-US/docs/Web/API/Document/xmlVersion
    • /zh-TW/docs/Web/API/Document/xmlStandalone does not exist
    • /zh-TW/docs/Web/API/Document/xmlEncoding does not exist but fell back to /en-US/docs/Web/API/Document/xmlEncoding
    • and 25 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en/JavaScript/Reference/Global_Objects/WeakMap
    • Can't resolve /en/E4X
    • Can't resolve /en/JavaScript/Reference/Functions_and_function_scope/Strict_mode
    • Can't resolve /en/DOM/event.stopImmediatePropagation
    • and 44 more flaws omitted

URL: /zh-TW/docs/Mozilla/Firefox/Releases/7
Title: Firefox 7 技術文件
on GitHub
Flaw count: 59

  • macros:
    • /zh-TW/docs/Web/API/HTMLHeadElement does not exist but fell back to /en-US/docs/Web/API/HTMLHeadElement
    • /zh-TW/docs/Web/HTML/Element/body does not exist but fell back to /en-US/docs/Web/HTML/Element/body
    • /zh-TW/docs/Web/HTML/Element/body does not exist but fell back to /en-US/docs/Web/HTML/Element/body
    • /zh-TW/docs/Web/HTML/Element/option does not exist but fell back to /en-US/docs/Web/HTML/Element/option
    • /zh-TW/docs/Web/HTML/Element/option does not exist but fell back to /en-US/docs/Web/HTML/Element/option
    • and 25 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /en/DOM/CanvasRenderingContext2D#isPointInPath()
    • Can't resolve /en/DOM/CanvasRenderingContext2D#drawImage()
    • Can't resolve /en/DOM/CanvasRenderingContext2D#drawImage()
    • Can't resolve /en/Canvas_tutorial/Applying_styles_and_colors#Shadows
    • and 22 more flaws omitted
  • sectioning:
    • Excess <h3> tag that is NOT at root-level (id='web_timing', text='Web timing')
    • Excess <h3> tag that is NOT at root-level (id='xml', text='XML')

URL: /zh-TW/docs/Mozilla/Firefox/Releases/11
Title: Firefox 11 技術文件
on GitHub
Flaw count: 39

  • macros:
    • /zh-TW/docs/Web/HTML/Element/audio does not exist but fell back to /en-US/docs/Web/HTML/Element/audio
    • /zh-TW/docs/Web/HTML/Element/video does not exist but fell back to /en-US/docs/Web/HTML/Element/video
    • /zh-TW/docs/Web/API/Element/outerHTML does not exist but fell back to /en-US/docs/Web/API/Element/outerHTML
    • /zh-TW/docs/Web/API/Window/navigator/mozVibrate does not exist
    • /zh-TW/docs/Web/API/Window/navigator/mozApps does not exist
    • and 5 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/HTML_in_XMLHttpRequest
    • Can't resolve /en-US/docs/DOM/Apps
    • Can't resolve /en-US/docs/Apps
    • Can't resolve /en-US/docs/DOM/HTMLMediaElement
    • Can't resolve /en-US/docs/DOM/HTMLMediaElement
    • and 24 more flaws omitted

External URLs

URL: /zh-CN/docs/Mozilla/Firefox/Releases/22
Title: Firefox 22 for developers
on GitHub

No new external URLs

URL: /zh-CN/docs/Mozilla/Firefox/Releases/15
Title: Firefox 15 for developers
on GitHub

No new external URLs

URL: /zh-CN/docs/Mozilla/Firefox/Releases/32
Title: Firefox 32 for developers
on GitHub

No new external URLs

URL: /zh-CN/docs/Mozilla/Firefox/Releases/12
Title: Firefox 12 for developers
on GitHub

No new external URLs

URL: /zh-CN/docs/Web/API/Window/innerHeight
Title: Window.innerHeight
on GitHub

No new external URLs

URL: /zh-TW/docs/orphaned/Mozilla/Firefox/Releases/4/Firefox_4_開發者新功能概覽
Title: Firefox 4 for developers
on GitHub

No new external URLs

URL: /zh-TW/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 技術文件
on GitHub

No new external URLs

URL: /zh-TW/docs/Mozilla/Firefox/Releases/10
Title: Firefox 10 技術文件
on GitHub

No new external URLs

URL: /zh-TW/docs/Mozilla/Firefox/Releases/7
Title: Firefox 7 技術文件
on GitHub

No new external URLs

URL: /zh-TW/docs/Mozilla/Firefox/Releases/11
Title: Firefox 11 技術文件
on GitHub

No new external URLs

(this comment was updated 2022-05-10 08:02:42.131839)
@irvin irvin merged commit d99c641 into mdn:main May 10, 2022
@yin1999 yin1999 deleted the remove-macros branch May 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
2 participants
@yin1999 @irvin