Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] fix broken link to W3C in banner_role page #21766

Merged
merged 1 commit into from
Jun 30, 2024
Merged

[fr] fix broken link to W3C in banner_role page #21766

merged 1 commit into from
Jun 30, 2024

Conversation

floriannari
Copy link
Contributor

Description

Update link from https://www.w3.org/TR/wai-aria/roles#banner to https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/banner.html

Motivation

https://www.w3.org/TR/wai-aria/roles#banner is broken

Additional details

Related issues and pull requests
@floriannari floriannari requested a review from a team as a code owner June 20, 2024 14:51
@floriannari floriannari requested review from cw118 and removed request for a team June 20, 2024 14:51
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (8)

URL: /fr/docs/Web/Accessibility/ARIA/Roles/banner_role
Title: Utilisation du rôle banner
Flaw count: 8

  • macros:
    • /fr/docs/Web/Accessibility/Information_for_Web_authors does not exist but fell back to /en-US/docs/Web/Accessibility/Information_for_Web_authors
    • /fr/docs/Web/Accessibility/Accessibility:_What_users_can_to_to_browse_safely does not exist but fell back to /en-US/docs/Web/Accessibility/Accessibility:_What_users_can_to_to_browse_safely
    • /fr/docs/Web/Accessibility/Cognitive_accessibility does not exist but fell back to /en-US/docs/Web/Accessibility/Cognitive_accessibility
    • /fr/docs/Web/Accessibility/Accessibility_and_Spacial_Patterns does not exist but fell back to /en-US/docs/Web/Accessibility/Accessibility_and_Spacial_Patterns
    • /fr/docs/Web/Accessibility/Understanding_Colors_and_Luminance does not exist but fell back to /en-US/docs/Web/Accessibility/Understanding_Colors_and_Luminance
    • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 1 possible)
External URLs (1)

URL: /fr/docs/Web/Accessibility/ARIA/Roles/banner_role
Title: Utilisation du rôle banner
@cw118 cw118 added this to 👀 Review requested in l10n-fr Jun 30, 2024
cw118
cw118 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this correction @floriannari !
@cw118 cw118 merged commit ef4bdf5 into mdn:main Jun 30, 2024
6 checks passed
l10n-fr automation moved this from 👀 Review requested to ✅ Done Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
2 participants
@floriannari @cw118