Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] fix typo in Web/API/fetch code example #21052

Merged
merged 3 commits into from
Jun 30, 2024
Merged

[fr] fix typo in Web/API/fetch code example #21052

merged 3 commits into from
Jun 30, 2024

Conversation

kiuxfr
Copy link
Contributor

@kiuxfr kiuxfr commented May 31, 2024

Description

typo in the code example

Motivation

fix syntax error

Additional details

Related issues and pull requests
@kiuxfr kiuxfr requested a review from a team as a code owner May 31, 2024 07:07
@kiuxfr kiuxfr requested review from SphinxKnight and removed request for a team May 31, 2024 07:07
@github-actions github-actions bot added the l10n-fr Issues related to French content. label May 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

Preview URLs

Flaws (17)

URL: /fr/docs/Web/API/fetch
Title: GlobalFetch.fetch()
Flaw count: 17

  • macros:
    • /fr/docs/Web/API/GlobalFetch/fetch redirects to /fr/docs/Web/API/fetch
    • /fr/docs/Web/API/Response/status does not exist but fell back to /en-US/docs/Web/API/Response/status
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/API/USVString
    • Wrong xref macro used (consider changing which macro you use). Error processing path /fr/docs/Web/API/ByteString
    • /fr/docs/Web/API/BufferSource does not exist
    • and 6 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Web/HTTP/Headers/origin
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /fr/docs/HTTP/Access_control_CORS
    • Can't resolve /fr/docs/HTTP
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

(comment last updated: 2024-06-30 21:21:46)
@leon-win leon-win changed the title Fix code example Jun 6, 2024
@cw118 cw118 added this to 👀 Review requested in l10n-fr Jun 30, 2024
cw118
cw118 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@cw118 cw118 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here @kiuxfr ! Thank you for the PR 🙏

N.B. I allowed myself to push a commit to run the checks
@cw118 cw118 merged commit 7937205 into mdn:main Jun 30, 2024
7 checks passed
l10n-fr automation moved this from 👀 Review requested to ✅ Done Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
2 participants
@kiuxfr @cw118