Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool): color-mix tool increase height of the output text #185

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Jul 1, 2024

When the output text wraps the controls get pushed down:

colorMixer-2024-07-01_18.28.25.mp4

Solution

Increase output text height.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 1, 2024 13:00
@OnkarRuikar OnkarRuikar requested review from pepelsbey and removed request for a team July 1, 2024 13:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also do this if you want to get rid of the janky values at integers:

        percentageOne.addEventListener("input", (e) => {
          let valueFixed = parseFloat(e.target.value).toFixed(1);
          percentageOneLabel.innerText = valueFixed + "%";
          updateColorMix();
        });
        percentageTwo.addEventListener("input", (e) => {
          let valueFixed = parseFloat(e.target.value).toFixed(1);
          percentageTwoLabel.innerText = valueFixed + "%";
          updateColorMix();
        });
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway, LGTM 👍🏻

@bsmth bsmth merged commit f1fc4fe into mdn:main Jul 1, 2024
@OnkarRuikar OnkarRuikar deleted the patch-1 branch July 2, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants