Fix CSS Normal Flow: Inline demo #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue #33705 in mdn / content.
pepelsbey
requested changes
May 22, 2024
There was a problem hiding this comment.
Hey! Thanks for the help :) I’d suggest changing the approach a bit.
Since this example only uses HTML and no CSS, we don’t need the playable-css class name. But since it’s causing an error in JS, I’d instead remove all references to it from JS (all textareaCSS occurrences, basically). As for the editable class name, I don’t think it’s used anywhere in JS or CSS, so we don’t really need it here.
pepelsbey
added
bug
Fixes the issue textarea changes not being responsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mdn/content#33705
Description:
MDN URL
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flow_layout/Block_and_inline_layout_in_normal_flow
The first code example in the
Elements participating in an inline formatting contextsection is not interactive and
Resetbutton wasn't working.This PR fixes the issue.
Motivation:
.
Additional details:
.
Related issues and pull requests:
.