Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improvements to template files, formatter config #173

Merged
merged 4 commits into from
Mar 7, 2024
Merged

chore: Improvements to template files, formatter config #173

merged 4 commits into from
Mar 7, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Feb 28, 2024 •
edited
Loading

Similar to mdn/dom-examples#260, adding template workflows, formatting configs.

Also adds language to code blocks in accompanying docs files.

TODO

  • add CONTRIBUTING.md, link to it from README
@bsmth bsmth requested a review from pepelsbey February 28, 2024 10:17
pepelsbey
pepelsbey approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you :)

But if I’m nitpicking, I’d say that CODEOWNERS and .prettierignore files don’t have a final newline that’s required by the .editorconfig. It’s not going to cause any trouble, though :)
@bsmth
Copy link
Member Author

bsmth commented Mar 7, 2024

But if I’m nitpicking, I’d say that CODEOWNERS and .prettierignore files don’t have a final newline that’s required by the .editorconfig. It’s not going to cause any trouble, though :)

Good point, added in 15528b9

Thank you!
@bsmth bsmth merged commit eb01020 into mdn:main Mar 7, 2024
@bsmth bsmth deleted the template-docs branch March 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@bsmth @pepelsbey