Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-#163-Resolved #171

Closed
wants to merge 2 commits into from
Closed

Issue-#163-Resolved #171

wants to merge 2 commits into from

Conversation

pragyamishra56
Copy link

  1. Issue Number: Modern JS: don't use var in css-examples #163
  2. Description: Modernize JavaScript usage in css-examples.
  3. Resolution: Replaced 'var' with 'const/let'.
  4. Outcome: Enhanced code readability and adherence to modern standards.
@teoli2003
Copy link
Member

The problem here is that you have done a find & replace.

The goal is not to replace all var by let, but to use const where possible too. Also, there are likely cases where var is correct, or where more changes are needed (as var behaviour may be different, especially wrt scope)

Can you start with 1 file or 1 group of files?

@pragyamishra56
Copy link
Author

@teoli2003 Sir I appreciate the clarification. I agree that a more thorough approach is needed. I'll work on breaking down the changes into separate PRs for a more comprehensive review. Thanks for guiding me through this process.

@pragyamishra56 pragyamishra56 closed this by deleting the head repository Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants