Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various code issues #161

Merged
merged 13 commits into from
Dec 7, 2023
Merged

fix: various code issues #161

merged 13 commits into from
Dec 7, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Change descriptions are in git commit message titles.

@@ -3,13 +3,13 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width" />
<link href="../../css/editable-old.css" rel="stylesheet"></link>
<link href="../../css/editable-old.css" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No end slashes for these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed all link tag endings in commit

target-text/index.html Outdated Show resolved Hide resolved
target-text/index.html Outdated Show resolved Hide resolved
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Dec 6, 2023

I'll run prettier in a separate PR.

@teoli2003
Copy link
Member

teoli2003 commented Dec 7, 2023

I unfortunately read your comment after merging prettier…

To redeem myself, I'll do the merge.

Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 484774a into mdn:main Dec 7, 2023
@OnkarRuikar OnkarRuikar deleted the css_code_issues branch December 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants