ReadableStreamDefaultController.close() - invalid exception reasons #34690
+7
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Jul 8, 2024
| @@ -34,19 +29,15 @@ None ({{jsxref("undefined")}}). | |||
| ### Exceptions | |||
|
|
|||
| - {{jsxref("TypeError")}} | |||
| - : Thrown if the source object is not a `ReadableStreamDefaultController`. | |||
|
|
|||
| - : Thrown if `close()` is called when the stream is not readable — because it is already closed, cancelled, or errored — or because it has been requested to close by the underlying source but it has not yet done so because there are still enqueued chunks to read. | |||
There was a problem hiding this comment.
This is the only content change.
|
Preview URLs External URLs (1)URL:
|
|
Is this intended to close #34597? |
|
@Josh-Cena No, it only partially fixes it. The original comment states that there the same problem is found in some nearby issues. I didn't look at those, though I will later if no one else does. |
|
Ok; because the PR description containing the substring "fixes #xxx", even if prefixed by "partially", would link this PR. |
|
Thanks @Josh-Cena - I didn't realize it was that sensitive. Have modified to something that hopefully wouldn't trigger a close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #34597
Also some layout only fixes.