Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: touchCache should be var or let, not const #34653

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Conversation

ragul1697
Copy link
Contributor

Description

Fixes #33665 issue being reassigning value to a const variable.

@ragul1697 ragul1697 requested a review from a team as a code owner July 5, 2024 10:35
@ragul1697 ragul1697 requested review from Elchi3 and removed request for a team July 5, 2024 10:35
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Preview URLs

(comment last updated: 2024-07-06 14:55:40)

Comment on lines 114 to 121
clearTouchCache();
}
}
}

function clearTouchCache() {
tpCache.length = 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a separate function is not necessary here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Now I moved it to the else part

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 6, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit 5197e68 into mdn:main Jul 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
3 participants