Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify resolution and default of URL-related manifest members #34638

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Clarify resolution and default of URL-related manifest members #34638

merged 2 commits into from
Jul 5, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #34519
@Josh-Cena Josh-Cena requested a review from a team as a code owner July 4, 2024 23:39
@Josh-Cena Josh-Cena requested review from hamishwillee and removed request for a team July 4, 2024 23:39
@github-actions github-actions bot added Content:Manifest size/s [PR only] 6-50 LoC changed labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-05 02:01:18)
@Josh-Cena @sideshowbarker
Apply suggestions from code review
9e85267 
Co-authored-by: sideshowbarker <mike@w3.org>
@sideshowbarker sideshowbarker merged commit 6652e67 into mdn:main Jul 5, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the manifest-url branch July 5, 2024 02:19
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 5, 2024
@Josh-Cena @evelinabe
Clarify resolution and default of URL-related manifest members (mdn#3…
3ff4145 
…4638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Manifest size/s [PR only] 6-50 LoC changed
2 participants
@Josh-Cena @sideshowbarker