Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added release note for CSSPropertyRule and registerProperty #34625

Merged
merged 10 commits into from
Jul 8, 2024
Merged

added release note for CSSPropertyRule and registerProperty #34625

merged 10 commits into from
Jul 8, 2024
+4 −44

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jul 4, 2024 •
edited
Loading

Description

  • Added Firefox release note for CSSPropertyRule
  • Added Firefox release note for registerProperty
  • Removed experimental release note for CSS Properties and Values API

Motivation

Working on issue 33993
@dletorey dletorey requested a review from a team as a code owner July 4, 2024 15:48
@dletorey dletorey requested review from Elchi3 and removed request for a team July 4, 2024 15:48
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/MediaKeys/getStatusForPolicy does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/HTTP/Headers/Priority
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers

(comment last updated: 2024-07-08 13:14:32)
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jul 4, 2024
@dletorey dletorey mentioned this pull request Jul 4, 2024
Open
8 tasks
@dipikabh dipikabh self-requested a review July 4, 2024 16:09
@dletorey dletorey requested a review from dipikabh July 8, 2024 11:05
dipikabh
dipikabh requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dletorey! I've added a few suggestions
files/en-us/mozilla/firefox/releases/128/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/128/index.md Outdated Show resolved Hide resolved
dletorey and others added 3 commits July 8, 2024 14:12
@dletorey @dipikabh
Update files/en-us/mozilla/firefox/releases/128/index.md
4ffcd15 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/mozilla/firefox/releases/128/index.md
654d587 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey
Merge branch 'main' into 33993-css-properties-values-api
dca55f8
@dletorey dletorey requested a review from dipikabh July 8, 2024 13:37
dletorey
dletorey commented Jul 8, 2024
View reviewed changes
Copy link
Contributor Author

@dletorey dletorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done
dipikabh
dipikabh approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍
@dipikabh dipikabh merged commit 9253f1e into mdn:main Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
2 participants
@dletorey @dipikabh