Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that class and ID selector values must be valid CSS identifiers #34601

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Document that class and ID selector values must be valid CSS identifiers #34601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bbdb14
Document that class and ID selector values must be valid CSS identifiers
wbamberg Jul 3, 2024
92d1ab2
Add escaping examples for class selectors
wbamberg Jul 3, 2024
0412411
Add escaping example for id selectors
wbamberg Jul 3, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add escaping example for id selectors
  • Loading branch information
@wbamberg
wbamberg committed Jul 3, 2024
commit 0412411fa0f640e4f6badefe103502689ee6735f
4 changes: 2 additions & 2 deletions files/en-us/web/css/class_selectors/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Note that this is equivalent to the following [attribute selector](/en-US/docs/W
[class~=class_name] { style properties }
```

The `class_name` value must be a valid [CSS identifier](/en-US/docs/Web/CSS/ident).
The `class_name` value must be a valid [CSS identifier](/en-US/docs/Web/CSS/ident). HTML `class` attributes which are not valid CSS identifiers must be [escaped](/en-US/docs/Web/CSS/ident#escaping_characters) before they can be used in class selectors.

## Examples

Expand Down Expand Up @@ -99,7 +99,7 @@ that contain characters which must be escaped in CSS -->

### Invalid class selectors

Class selectors must be valid CSS identifiers.
The class selectors in the following rules are not valid CSS identifiers, and will be ignored.

```css example-bad
.item?one {
Expand Down
32 changes: 26 additions & 6 deletions files/en-us/web/css/id_selectors/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Note that syntactically (but not specificity-wise), this is equivalent to the fo
[id=id_value] { style properties }
```

The `id_value` value must be a valid [CSS identifier](/en-US/docs/Web/CSS/ident).
The `id_value` value must be a valid [CSS identifier](/en-US/docs/Web/CSS/ident). HTML `id` attributes which are not valid CSS identifiers must be [escaped](/en-US/docs/Web/CSS/ident#escaping_characters) before they can be used in class selectors.

## Examples

Expand All @@ -37,25 +37,45 @@ The `id_value` value must be a valid [CSS identifier](/en-US/docs/Web/CSS/ident)
#### HTML

```html
<div id="identified">This div has a special ID on it!</div>
<div>This is just a regular div.</div>
<p id="blue">This paragraph has a blue background.</p>
<p>This is just a regular paragraph.</p>
```

```html
<!-- The next two paragraphs have id attributes
that contain characters which must be escaped in CSS -->

<p id="item?one">This paragraph has a pink background.</p>
<p id="123item">This paragraph has a yellow background.</p>
```

#### CSS

```css
#identified {
#blue {
background-color: skyblue;
}
```

```css
/* In the next two rules, the id attributes must be escaped */

#item\?one {
background-color: pink;
}

#\00003123item {
background-color: yellow;
}
```

#### Result

{{EmbedLiveSample("Examples", '100%', 50)}}
{{EmbedLiveSample("Examples", '100%', 200)}}

### Invalid ID selectors

ID selectors must be valid CSS identifiers.
The ID selectors in the following rules are not valid CSS identifiers, and will be ignored.

```css example-bad
#item?one {
Expand Down