Update description of GPUColorWrite constants in WebGPU #34520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
||
| Note that multiple flags can be specified by separating values with pipe symbols, for example: | ||
|
|
||
| ```js | ||
| writeMask: GPUFlagsConstant.RED | GPUFlagsConstant.ALPHA; | ||
| writeMask: GPUColorWrite.RED | GPUColorWrite.ALPHA |
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| writeMask: GPUColorWrite.RED | GPUColorWrite.ALPHA | |
| writeMask: GPUColorWrite.RED | GPUColorWrite.ALPHA; |
|
Preview URLs (comment last updated: 2024-06-30 21:11:35) |
wbamberg
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The WebGPU createRenderPipeline call takes bitwise flags as parameters but I think they were mislabeled on the docs. I've updated them to the correct name.
Motivation
Following the way in which the flags were originally described on the docs, you would get a JavaScript ReferenceError saying 'GPUFlagsConstant is not defined'.
Additional details
WebGPU documentation for GPUColorWrite: https://www.w3.org/TR/webgpu/#namespacedef-gpucolorwrite