Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention that not must be used with media type #34509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove mention that not must be used with media type #34509

wants to merge 1 commit into from
+16 −5

Conversation

Josh-Cena
Copy link
Member

Fix #32320
@Josh-Cena Josh-Cena requested a review from a team as a code owner June 29, 2024 19:00
@Josh-Cena Josh-Cena requested review from estelle and removed request for a team June 29, 2024 19:00
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed labels Jun 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs
estelle
estelle reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this.

Just one comment: There's a phrase Idon't fully understand.
files/en-us/web/css/css_media_queries/using_media_queries/index.md
@@ -180,7 +180,7 @@ The `and` operator can also combine multiple media features into a single media
The `only` operator prevents older browsers from applying the styles.

> **Note:** In most cases, the `all` media type is used by default when no other type is specified.
> However, if you use the `not` or `only` operators, you must explicitly specify a media type.
> However, if you use the `only` operator, you must explicitly specify a media type. You can see `only screen` or `only print` as a whole.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what "as a whole" means here. Line 180 likely needs to be updated and congruent with this intended content.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: you can see only screen and only print as if it's a media type as a whole. This is because only (screen) or only (screen and (width < 100px)) don't work either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Learn:CSS Learning area CSS docs size/s [PR only] 6-50 LoC changed
2 participants
@Josh-Cena @estelle