Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for HTMLLinkElement.media #33641

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Add docs for HTMLLinkElement.media #33641

merged 4 commits into from
Jul 12, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented May 16, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

part of the mdn/mdn#520

relates to mdn/browser-compat-data#23111
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 16, 2024
@skyclouds2001 skyclouds2001 mentioned this pull request May 16, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

Preview URLs

Flaws (4)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLLinkElement
Title: HTMLLinkElement
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLLinkElement/sizes does not exist
    • /en-US/docs/Web/API/HTMLLinkElement/charset does not exist
    • /en-US/docs/Web/API/HTMLLinkElement/rev does not exist
    • /en-US/docs/Web/API/HTMLLinkElement/target does not exist

(comment last updated: 2024-07-09 06:43:02)
@teoli2003
Copy link
Member

Any reason this is still a draft?
@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 28, 2024 17:38
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner May 28, 2024 17:38
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team May 28, 2024 17:38
Josh-Cena
Josh-Cena approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think this is sufficient as a basic doc.
@Josh-Cena Josh-Cena merged commit 167bf62 into mdn:main Jul 12, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the HTMLLinkElement.media branch July 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
3 participants
@skyclouds2001 @teoli2003 @Josh-Cena